ci: aggregate checks with guardian #20635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
lantiga,
tchaton,
justusschock and
ethanwharris
as code owners
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20635 +/- ##
========================================
- Coverage 88% 87% -1%
========================================
Files 267 267
Lines 23372 23372
========================================
- Hits 20483 20237 -246
- Misses 2889 3135 +246 🚀 New features to boost your workflow:
|
justusschock
approved these changes
Mar 11, 2025
7 tasks
tchaton
approved these changes
Mar 11, 2025
Borda
added a commit
that referenced
this pull request
Mar 12, 2025
(cherry picked from commit 02e2668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
since almost all these cases are required, we can aggregate them into one check
even we use required jobs, it is quite tricky to have all cases listed and dont miss one
so this will make it easier if we need all and if just a subset we can specify it
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20635.org.readthedocs.build/en/20635/
cc @Borda @lantiga